Handle state evolution without breaking state compatibility #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Thanks. Tests were left in Flink 1.x API, however it would be better to make them available for both Flink versions. I do not have an idea how this can be done at the moment. We should not duplicate tests, because it will add even more maintenance work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @novakov-alexey,
As designed in the issue #240, here is my proposal to handle state evolution without breaking state compatibility.
ScalaCaseObjectSerializerhas not the issue because it doesn't serialize serializers, but I addedMapSerializerin addition of the previous list.Write a test that reproduces the issue and shows this PR fixes it was hard, please have a look at
MapSerializerSnapshotTest. I didn't write a test for each serializer snapshot, but the logic is the same.I was surprised to see no tests for Flink 2, I created the root test folder, but maybe tests for Flink 1 should be duplicated for Flink 2 also?
As said in the issue, I can also do these changes for Flink 1, but it will break the state compatibility.
Thanks